Change in osmo-hlr[master]: fix USSD routing to multiple MSC

osmith gerrit-no-reply at lists.osmocom.org
Fri Apr 5 08:51:57 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13479 )

Change subject: fix USSD routing to multiple MSC
......................................................................


Patch Set 4:

(3 comments)

Neels asked me to finish this up.

https://gerrit.osmocom.org/#/c/13479/4/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/13479/4/src/hlr_ussd.c@255
PS4, Line 255: strlen(subscr->vlr_number)
This must be

 strlen(subscr->vlr_number) + 1

or else it does not work. At least when setting ipa-name in osmo-msc.cfg.

I've added debug prints in gsup_route_find() [1] and this is how the compare fails without the +1:

 gsup route find: "MSC-13-37-00-00-00-00", len: 21
 gsup route find: comparing with: "MSC-13-37-00-00-00-00\0", len: 22

[1]: https://git.osmocom.org/osmo-hlr/tree/src/gsup_router.c?id=3cf87fe22cf53178ddd4f7e5c4be67ca8c4bc8bd#n37

Fixed in patchset #5.


https://gerrit.osmocom.org/#/c/13479/4/src/hlr_ussd.c@335
PS4, Line 335: ss->subscr = NULL;
> I think doing this manually is not a good idea... […]
I have added a timer and set it to 10 seconds.


https://gerrit.osmocom.org/#/c/13479/4/src/hlr_ussd.c@338
PS4, Line 338: 		ss_tx_error(ss, true, GSM0480_ERR_CODE_UNKNOWN_SUBSCRIBER);
> > should probably also somehow remember which MSC initiated the session? […]
See my follow up patch here:

https://gerrit.osmocom.org/#/c/osmo-hlr/+/13515/

Is this the right approach?

Vadim, since Neels is super busy with finishing up MSC handover stuff, maybe you can take a look at it?



-- 
To view, visit https://gerrit.osmocom.org/13479
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18067bfadd33a6bc59a9ee336b6937313826fce3
Gerrit-Change-Number: 13479
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Apr 2019 08:51:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190405/929d0d91/attachment.html>


More information about the gerrit-log mailing list