Change in osmo-msc[master]: msc/gsm_data.h: fix and clarify GSM 03.40 TP-UD Length

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Apr 2 11:53:59 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13484 )

Change subject: msc/gsm_data.h: fix and clarify GSM 03.40 TP-UD Length
......................................................................


Patch Set 2:

(2 comments)

osmo-msc merge wise this should be fine to be merged.

https://gerrit.osmocom.org/#/c/13484/2/include/osmocom/msc/gsm_data.h
File include/osmocom/msc/gsm_data.h:

https://gerrit.osmocom.org/#/c/13484/2/include/osmocom/msc/gsm_data.h@242
PS2, Line 242: /* TODO: Move these defines to libosmogsm (gsm/protocol/gsm_03_40.h) */
(why not add them there then from the start?)


https://gerrit.osmocom.org/#/c/13484/2/include/osmocom/msc/gsm_data.h@284
PS2, Line 284: 	/* Since we always store TP-UD in octets, even if it does contain
("we store in octets" to me sounds like we store each septet in an octet. I'd call it "this stores raw packed septets"?)



-- 
To view, visit https://gerrit.osmocom.org/13484
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a49f9d24cd075234190b3b92999256bce01ca77
Gerrit-Change-Number: 13484
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Assignee: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Apr 2019 11:53:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190402/9e5dfeb8/attachment.html>


More information about the gerrit-log mailing list