Change in osmo-msc[master]: msc/gsm_data.h: fix and clarify GSM 03.40 TP-UD Length

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Apr 2 10:11:59 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13484 )

Change subject: msc/gsm_data.h: fix and clarify GSM 03.40 TP-UD Length
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/13484/1/include/osmocom/msc/gsm_data.h
File include/osmocom/msc/gsm_data.h:

https://gerrit.osmocom.org/#/c/13484/1/include/osmocom/msc/gsm_data.h@242
PS1, Line 242: /* TODO: Move these defines to libosmogsm (gsm/protocol/gsm_03_40.h) */
> Can you add "3GPP TS 03.40, section 9.2.3. […]
Sure!


https://gerrit.osmocom.org/#/c/13484/1/include/osmocom/msc/gsm_data.h@287
PS1, Line 287: 	uint8_t user_data[GSM340_UDL_OCT_MAX];
> iiuc, we use 1 octet for each 7bit-digit, which means we still need more space than we should use GS […]
No, we don't use 1 octet for each 7bit-digit. Check out the definition of sms_from_text() for example:

  sms->user_data_len = gsm_7bit_encode_n(sms->user_data, sizeof(sms->user_data), sms->text, NULL);



-- 
To view, visit https://gerrit.osmocom.org/13484
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a49f9d24cd075234190b3b92999256bce01ca77
Gerrit-Change-Number: 13484
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Assignee: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Apr 2019 10:11:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190402/f921ecb7/attachment.html>


More information about the gerrit-log mailing list