Change in osmo-msc[master]: a_iface_bssap: check bssmap length field
gerrit-no-reply at lists.osmocom.org
Mon Apr 1 15:12:31 UTC 2019
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13307 )
Change subject: a_iface_bssap: check bssmap length field
Patch Set 5:
> In current osmo-msc refactoring, I have the same checks in place,
> except my version discards the messages completely.
> Maybe we should truncate if extra bytes are present, and discard if
> too few bytes are present? What do you think?
I had a look at your code. To me it looks ok to discard the whole message if there is excess data as it either means that the message was damaged of the receiving end has some significant problems. However, the ticket that is related to the task says that the message should only be truncated: http://osmocom.org/issues/3806
> Either way let's avoid the merge conflict and not merge this
> version. Rather apply to branch neels/ho file nas_a.c.
I am fine with abandoning this, if it avoids merge conflicts.
PS1, Line 7: bssmap
PS1, Line 721: _header = (struct bssmap_header *)msg->l2h;
> on the MSC side we cannot have log messages without any context. […]
PS1, Line 722:
> Same as other patch: "extraneous". Better use "extra".
To view, visit https://gerrit.osmocom.org/13307
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Apr 2019 15:12:31 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log