Change in osmo-msc[master]: a_iface_bssap: check bssmap length field

dexter gerrit-no-reply at lists.osmocom.org
Mon Apr 1 15:12:31 UTC 2019


dexter has posted comments on this change. ( https://gerrit.osmocom.org/13307 )

Change subject: a_iface_bssap: check bssmap length field
......................................................................


Patch Set 5:

(3 comments)

> In current osmo-msc refactoring, I have the same checks in place,
 > except my version discards the messages completely.
 > http://git.osmocom.org/osmo-msc/tree/src/libmsc/nas_a.c?h=neels/ho#n555
 > 
 > Maybe we should truncate if extra bytes are present, and discard if
 > too few bytes are present? What do you think?

I had a look at your code. To me it looks ok to discard the whole message if there is excess data as it either means that the message was damaged of the receiving end has some significant problems. However, the ticket that is related to the task says that the message should only be truncated: http://osmocom.org/issues/3806

 > Either way let's avoid the merge conflict and not merge this
 > version. Rather apply to branch neels/ho file nas_a.c.

I am fine with abandoning this, if it avoids merge conflicts.

https://gerrit.osmocom.org/#/c/13307/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13307/1//COMMIT_MSG@7
PS1, Line 7: bssmap
> bssmap
Done


https://gerrit.osmocom.org/#/c/13307/1/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:

https://gerrit.osmocom.org/#/c/13307/1/src/libmsc/a_iface_bssap.c@721
PS1, Line 721: _header = (struct bssmap_header *)msg->l2h;
             : 
> on the MSC side we cannot have log messages without any context. […]
Done


https://gerrit.osmocom.org/#/c/13307/1/src/libmsc/a_iface_bssap.c@722
PS1, Line 722: 
> Same as other patch: "extraneous". Better use "extra".
Done



-- 
To view, visit https://gerrit.osmocom.org/13307
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b89dd5a66ec83b03860b58b6b8eb58007f433a4
Gerrit-Change-Number: 13307
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Apr 2019 15:12:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190401/1a17638c/attachment.html>


More information about the gerrit-log mailing list