Change in osmo-msc[master]: a_iface_bssap: check bssmap length field

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Apr 1 12:08:50 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13307 )

Change subject: a_iface_bssap: check bssmap length field
......................................................................


Patch Set 5: Code-Review-2

In current osmo-msc refactoring, I have the same checks in place,
except my version discards the messages completely.
http://git.osmocom.org/osmo-msc/tree/src/libmsc/nas_a.c?h=neels/ho#n555

Maybe we should truncate if extra bytes are present, and discard if too few bytes are present? What do you think?

Either way let's avoid the merge conflict and not merge this version. Rather apply to branch neels/ho file nas_a.c.


-- 
To view, visit https://gerrit.osmocom.org/13307
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b89dd5a66ec83b03860b58b6b8eb58007f433a4
Gerrit-Change-Number: 13307
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Apr 2019 12:08:50 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190401/3494a12d/attachment.html>


More information about the gerrit-log mailing list