Change in libosmo-sccp[master]: allow less characters for SCCP address book entries

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Sep 27 00:49:36 UTC 2018


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11112


Change subject: allow less characters for SCCP address book entries
......................................................................

allow less characters for SCCP address book entries

Allowing a whole line of characters as address book name would be a lot,
allowing 512 characters is completely ridiculous. That's more than this entire
commit log message! 32 is plenty.

Though libosmo-sigtran becomes binary-backwards-incompatible, all linking
programs should automatically get the limitation in their VTY parsing without
any changes.

Change-Id: I3ecf83d620e46f7bf9857fc60a93d4e240ee3b8a
---
M src/osmo_ss7_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/12/11112/1

diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index 2f70bb6..c66a781 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -1018,7 +1018,7 @@
 	struct llist_head list;
 	struct llist_head list_global;
 	struct osmo_ss7_instance *inst;
-	char name[512];
+	char name[32];
 	struct osmo_sccp_addr addr;
 };
 

-- 
To view, visit https://gerrit.osmocom.org/11112
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ecf83d620e46f7bf9857fc60a93d4e240ee3b8a
Gerrit-Change-Number: 11112
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180927/a0c01a7d/attachment.htm>


More information about the gerrit-log mailing list