Change in libosmo-sccp[master]: allow less characters for SCCP address book entries

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Sep 27 06:59:48 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11112 )

Change subject: allow less characters for SCCP address book entries
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/11112/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11112/1//COMMIT_MSG@11
PS1, Line 11: 32 is plenty
please note that the RKM and other code dynamically generates names (and I don't know what the max generated length is), but I think only for ASP and AS, not for SCCP address book entries.


https://gerrit.osmocom.org/#/c/11112/1//COMMIT_MSG@13
PS1, Line 13: Though libosmo-sigtran becomes binary-backwards-incompatible
whoy does it become incompatible?  The structure you modified is not in a header file but only in a C file.  It seems entirely self-contained.  So the only incompatibility that should occur is if somebody used names > 32 characters length.



-- 
To view, visit https://gerrit.osmocom.org/11112
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ecf83d620e46f7bf9857fc60a93d4e240ee3b8a
Gerrit-Change-Number: 11112
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Thu, 27 Sep 2018 06:59:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180927/f5f6326d/attachment.htm>


More information about the gerrit-log mailing list