Change in libosmocore[master]: vty/command.h: document and prettify CMD_ATTR_* flags

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11072 )

Change subject: vty/command.h: document and prettify CMD_ATTR_* flags
......................................................................

vty/command.h: document and prettify CMD_ATTR_* flags

Since the CMD_ATTR_* flags are intended to be used in bitwise
operations, let's assign them proper values. Adding a new flag
(e.g. CMD_ATTR_FOO_BAR) could actually result in assigning 0x03
instead of expected (0x01 << 2).

Change-Id: I3b1badef830f7e6436a67673b5709ec33c060c68
Related: OS#3584
---
M include/osmocom/vty/command.h
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/vty/command.h b/include/osmocom/vty/command.h
index 13d6e89..d63dbde 100644
--- a/include/osmocom/vty/command.h
+++ b/include/osmocom/vty/command.h
@@ -132,9 +132,10 @@
 	char name[64];
 };
 
+/*! Attributes (flags) for \ref cmd_element */
 enum {
-	CMD_ATTR_DEPRECATED = 1,
-	CMD_ATTR_HIDDEN,
+	CMD_ATTR_DEPRECATED	= (1 << 0),
+	CMD_ATTR_HIDDEN		= (1 << 1),
 };
 
 /*! Structure of a command element */

-- 
To view, visit https://gerrit.osmocom.org/11072
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b1badef830f7e6436a67673b5709ec33c060c68
Gerrit-Change-Number: 11072
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180924/4fd8841a/attachment.htm>