<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11072">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty/command.h: document and prettify CMD_ATTR_* flags<br><br>Since the CMD_ATTR_* flags are intended to be used in bitwise<br>operations, let's assign them proper values. Adding a new flag<br>(e.g. CMD_ATTR_FOO_BAR) could actually result in assigning 0x03<br>instead of expected (0x01 << 2).<br><br>Change-Id: I3b1badef830f7e6436a67673b5709ec33c060c68<br>Related: OS#3584<br>---<br>M include/osmocom/vty/command.h<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/vty/command.h b/include/osmocom/vty/command.h</span><br><span>index 13d6e89..d63dbde 100644</span><br><span>--- a/include/osmocom/vty/command.h</span><br><span>+++ b/include/osmocom/vty/command.h</span><br><span>@@ -132,9 +132,10 @@</span><br><span>        char name[64];</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/*! Attributes (flags) for \ref cmd_element */</span><br><span> enum {</span><br><span style="color: hsl(0, 100%, 40%);">-      CMD_ATTR_DEPRECATED = 1,</span><br><span style="color: hsl(0, 100%, 40%);">-        CMD_ATTR_HIDDEN,</span><br><span style="color: hsl(120, 100%, 40%);">+      CMD_ATTR_DEPRECATED     = (1 << 0),</span><br><span style="color: hsl(120, 100%, 40%);">+     CMD_ATTR_HIDDEN         = (1 << 1),</span><br><span> };</span><br><span> </span><br><span> /*! Structure of a command element */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11072">change 11072</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11072"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I3b1badef830f7e6436a67673b5709ec33c060c68 </div>
<div style="display:none"> Gerrit-Change-Number: 11072 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>