Change in osmo-ttcn3-hacks[master]: compare_results.sh: speed up comparison loop

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/10799 )

Change subject: compare_results.sh: speed up comparison loop
......................................................................

compare_results.sh: speed up comparison loop

The script takes quite long to parse each and every line O(n**2). Rather
directly pick only those lines that contain the test name in the grep that
feeds into the loop.

Change-Id: I0d4987b11c3feaef3a7fc56d764c43386865004f
---
M compare-results.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Neels Hofmeyr: Looks good to me, approved; Verified



diff --git a/compare-results.sh b/compare-results.sh
index cb80a0d..708f59d 100755
--- a/compare-results.sh
+++ b/compare-results.sh
@@ -112,7 +112,7 @@
     fi
     matched="1"
     break
-  done <<< "$(grep "<testcase" "$results_file")"
+  done <<< "$(grep "<testcase.*$exp_test_name" "$results_file")"
 
   if [ "x$matched" = "x0" ]; then
     echo "skipped $exp_suite_name.$exp_test_name"
@@ -140,7 +140,7 @@
 
     matched="1"
     break
-  done <<< "$(grep "<testcase" "$expected_file")"
+  done <<< "$(grep "<testcase.*$test_name" "$expected_file")"
 
   if [ "x$matched" = "x0" ]; then
     echo "NEW-$got_test_result $got_suite_name.$got_test_name"

-- 
To view, visit https://gerrit.osmocom.org/10799
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d4987b11c3feaef3a7fc56d764c43386865004f
Gerrit-Change-Number: 10799
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180906/b700238d/attachment.htm>