<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10799">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Neels Hofmeyr: Looks good to me, approved; Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">compare_results.sh: speed up comparison loop<br><br>The script takes quite long to parse each and every line O(n**2). Rather<br>directly pick only those lines that contain the test name in the grep that<br>feeds into the loop.<br><br>Change-Id: I0d4987b11c3feaef3a7fc56d764c43386865004f<br>---<br>M compare-results.sh<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/compare-results.sh b/compare-results.sh</span><br><span>index cb80a0d..708f59d 100755</span><br><span>--- a/compare-results.sh</span><br><span>+++ b/compare-results.sh</span><br><span>@@ -112,7 +112,7 @@</span><br><span>     fi</span><br><span>     matched="1"</span><br><span>     break</span><br><span style="color: hsl(0, 100%, 40%);">-  done <<< "$(grep "<testcase" "$results_file")"</span><br><span style="color: hsl(120, 100%, 40%);">+  done <<< "$(grep "<testcase.*$exp_test_name" "$results_file")"</span><br><span> </span><br><span>   if [ "x$matched" = "x0" ]; then</span><br><span>     echo "skipped $exp_suite_name.$exp_test_name"</span><br><span>@@ -140,7 +140,7 @@</span><br><span> </span><br><span>     matched="1"</span><br><span>     break</span><br><span style="color: hsl(0, 100%, 40%);">-  done <<< "$(grep "<testcase" "$expected_file")"</span><br><span style="color: hsl(120, 100%, 40%);">+  done <<< "$(grep "<testcase.*$test_name" "$expected_file")"</span><br><span> </span><br><span>   if [ "x$matched" = "x0" ]; then</span><br><span>     echo "NEW-$got_test_result $got_suite_name.$got_test_name"</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10799">change 10799</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10799"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0d4987b11c3feaef3a7fc56d764c43386865004f </div>
<div style="display:none"> Gerrit-Change-Number: 10799 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>