This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10700 ) Change subject: cosmetic: lchan activ: drop todo comments ...................................................................... cosmetic: lchan activ: drop todo comments Drop the todo comments about "for_conn->encr". I have intended that as an idea to store encryption info in the conn instead of the lchan, which might make sense, but there's no use in these comments. Change-Id: I47e90062c784dd7919fff3115e2bee3314b30cd5 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 28dc846..3352da5 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -447,14 +447,12 @@ lchan->activate.re_use_mgw_endpoint_from_lchan = info->old_lchan; if (info->old_lchan) { - /* TODO: rather take info->for_conn->encr? */ lchan->encr = info->old_lchan->encr; lchan->ms_power = info->old_lchan->ms_power; lchan->bs_power = info->old_lchan->bs_power; lchan->rqd_ta = info->old_lchan->rqd_ta; } else { struct gsm_bts *bts = lchan->ts->trx->bts; - /* TODO: rather take info->for_conn->encr? */ lchan->encr = (struct gsm_encr){ .alg_id = RSL_ENC_ALG_A5(0), /* no encryption */ }; -- To view, visit https://gerrit.osmocom.org/10700 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I47e90062c784dd7919fff3115e2bee3314b30cd5 Gerrit-Change-Number: 10700 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180904/8e24ff09/attachment.htm>