<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10700">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: lchan activ: drop todo comments<br><br>Drop the todo comments about "for_conn->encr". I have intended that as an idea<br>to store encryption info in the conn instead of the lchan, which might make<br>sense, but there's no use in these comments.<br><br>Change-Id: I47e90062c784dd7919fff3115e2bee3314b30cd5<br>---<br>M src/osmo-bsc/lchan_fsm.c<br>1 file changed, 0 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index 28dc846..3352da5 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -447,14 +447,12 @@</span><br><span>              lchan->activate.re_use_mgw_endpoint_from_lchan = info->old_lchan;</span><br><span> </span><br><span>          if (info->old_lchan) {</span><br><span style="color: hsl(0, 100%, 40%);">-                       /* TODO: rather take info->for_conn->encr? */</span><br><span>                  lchan->encr = info->old_lchan->encr;</span><br><span>                        lchan->ms_power = info->old_lchan->ms_power;</span><br><span>                        lchan->bs_power = info->old_lchan->bs_power;</span><br><span>                        lchan->rqd_ta = info->old_lchan->rqd_ta;</span><br><span>            } else {</span><br><span>                     struct gsm_bts *bts = lchan->ts->trx->bts;</span><br><span style="color: hsl(0, 100%, 40%);">-                     /* TODO: rather take info->for_conn->encr? */</span><br><span>                  lchan->encr = (struct gsm_encr){</span><br><span>                          .alg_id = RSL_ENC_ALG_A5(0),    /* no encryption */</span><br><span>                  };</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10700">change 10700</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10700"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I47e90062c784dd7919fff3115e2bee3314b30cd5 </div>
<div style="display:none"> Gerrit-Change-Number: 10700 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>