This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has uploaded this change for review. ( https://gerrit.osmocom.org/11514 Change subject: gsm0808: cosmetic: rename parameter "reason" to "cause" ...................................................................... gsm0808: cosmetic: rename parameter "reason" to "cause" The function that generates the clear command takes a parameter "reason", which is the cause code. Lets give it the name "cause" to have a coherent naming scheme that matches the other functions and the 3gpp specs. Change-Id: I7b6c15e8fa8db13deef5041095944ca1c58fb99f --- M include/osmocom/gsm/gsm0808.h M src/gsm/gsm0808.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/14/11514/1 diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h index f4fc7c4..cdbb273 100644 --- a/include/osmocom/gsm/gsm0808.h +++ b/include/osmocom/gsm/gsm0808.h @@ -45,7 +45,7 @@ const struct gsm0808_speech_codec_list *scl); struct msgb *gsm0808_create_reset(void); struct msgb *gsm0808_create_reset_ack(void); -struct msgb *gsm0808_create_clear_command(uint8_t reason); +struct msgb *gsm0808_create_clear_command(uint8_t cause); struct msgb *gsm0808_create_clear_complete(void); struct msgb *gsm0808_create_cipher(const struct gsm0808_encrypt_info *ei, const uint8_t *cipher_response_mode); diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c index ad90008..9ccca4d 100644 --- a/src/gsm/gsm0808.c +++ b/src/gsm/gsm0808.c @@ -182,9 +182,9 @@ } /*! Create BSSMAP Clear Command message - * \param[in] reason TS 08.08 cause value + * \param[in] cause TS 08.08 cause value * \returns callee-allocated msgb with BSSMAP Clear Command message */ -struct msgb *gsm0808_create_clear_command(uint8_t reason) +struct msgb *gsm0808_create_clear_command(uint8_t cause) { struct msgb *msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, BSSMAP_MSG_HEADROOM, "bssmap: clear command"); @@ -193,7 +193,7 @@ msg->l3h = msgb_tv_put(msg, BSSAP_MSG_BSS_MANAGEMENT, 4); msgb_v_put(msg, BSS_MAP_MSG_CLEAR_CMD); - msgb_tlv_put(msg, GSM0808_IE_CAUSE, 1, &reason); + msgb_tlv_put(msg, GSM0808_IE_CAUSE, 1, &cause); return msg; } -- To view, visit https://gerrit.osmocom.org/11514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7b6c15e8fa8db13deef5041095944ca1c58fb99f Gerrit-Change-Number: 11514 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181030/78a145a1/attachment.htm>