<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11514">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm0808: cosmetic: rename parameter "reason" to "cause"<br><br>The function that generates the clear command takes a parameter<br>"reason", which is the cause code. Lets give it the name "cause" to have<br>a coherent naming scheme that matches the other functions and the 3gpp<br>specs.<br><br>Change-Id: I7b6c15e8fa8db13deef5041095944ca1c58fb99f<br>---<br>M include/osmocom/gsm/gsm0808.h<br>M src/gsm/gsm0808.c<br>2 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/14/11514/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h</span><br><span>index f4fc7c4..cdbb273 100644</span><br><span>--- a/include/osmocom/gsm/gsm0808.h</span><br><span>+++ b/include/osmocom/gsm/gsm0808.h</span><br><span>@@ -45,7 +45,7 @@</span><br><span>                                    const struct gsm0808_speech_codec_list *scl);</span><br><span> struct msgb *gsm0808_create_reset(void);</span><br><span> struct msgb *gsm0808_create_reset_ack(void);</span><br><span style="color: hsl(0, 100%, 40%);">-struct msgb *gsm0808_create_clear_command(uint8_t reason);</span><br><span style="color: hsl(120, 100%, 40%);">+struct msgb *gsm0808_create_clear_command(uint8_t cause);</span><br><span> struct msgb *gsm0808_create_clear_complete(void);</span><br><span> struct msgb *gsm0808_create_cipher(const struct gsm0808_encrypt_info *ei,</span><br><span>                                   const uint8_t *cipher_response_mode);</span><br><span>diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c</span><br><span>index ad90008..9ccca4d 100644</span><br><span>--- a/src/gsm/gsm0808.c</span><br><span>+++ b/src/gsm/gsm0808.c</span><br><span>@@ -182,9 +182,9 @@</span><br><span> }</span><br><span> </span><br><span> /*! Create BSSMAP Clear Command message</span><br><span style="color: hsl(0, 100%, 40%);">- *  \param[in] reason TS 08.08 cause value</span><br><span style="color: hsl(120, 100%, 40%);">+ *  \param[in] cause TS 08.08 cause value</span><br><span>  *  \returns callee-allocated msgb with BSSMAP Clear Command message */</span><br><span style="color: hsl(0, 100%, 40%);">-struct msgb *gsm0808_create_clear_command(uint8_t reason)</span><br><span style="color: hsl(120, 100%, 40%);">+struct msgb *gsm0808_create_clear_command(uint8_t cause)</span><br><span> {</span><br><span>  struct msgb *msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, BSSMAP_MSG_HEADROOM,</span><br><span>                                                "bssmap: clear command");</span><br><span>@@ -193,7 +193,7 @@</span><br><span> </span><br><span>         msg->l3h = msgb_tv_put(msg, BSSAP_MSG_BSS_MANAGEMENT, 4);</span><br><span>         msgb_v_put(msg, BSS_MAP_MSG_CLEAR_CMD);</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_tlv_put(msg, GSM0808_IE_CAUSE, 1, &reason);</span><br><span style="color: hsl(120, 100%, 40%);">+  msgb_tlv_put(msg, GSM0808_IE_CAUSE, 1, &cause);</span><br><span> </span><br><span>      return msg;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11514">change 11514</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11514"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7b6c15e8fa8db13deef5041095944ca1c58fb99f </div>
<div style="display:none"> Gerrit-Change-Number: 11514 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>