This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgHello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11990 to look at the new patch set (#3). Change subject: library/GSUP_Types.ttcn: fix IE order in PROC_SS_ERROR templates ...................................................................... library/GSUP_Types.ttcn: fix IE order in PROC_SS_ERROR templates In general, the order of IEs in a GSUP message doesn't matter. Despite libosmocore's GSUP API encodes IEs in a fixed order, it is capable to decode them in any arbitary order. Meanwhile, in the current TTCN-3 definitions (i.e. templates) the order makes a difference, because the 'GSUP_IEs' type is a record, that according to the TTCN-3 documentation represents an *ordered* sequence of elements. Let's reorder the IEs of both t{r|s}_GSUP_PROC_SS_ERR templates in a way that is used by the libosmocore's GSUP encoder. This correction doesn't affect successful test case executions, because we don't test possible problematic situations yet. But if something went wrong on the HLR side (i.e. SUT), the matching statements wouldn't match the PROC_SS_ERR message correctly and continue to wait until the guard timer is expired. Change-Id: I5eb2314f6a9ab0e9fc5e836390414cec6e1a12db --- M library/GSUP_Types.ttcn 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/11990/3 -- To view, visit https://gerrit.osmocom.org/11990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5eb2314f6a9ab0e9fc5e836390414cec6e1a12db Gerrit-Change-Number: 11990 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181129/bbe02097/attachment.htm>