Change in osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: fix IE order in PROC_SS_ERROR templates

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 29 14:21:09 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11990 )

Change subject: library/GSUP_Types.ttcn: fix IE order in PROC_SS_ERROR templates
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/11990/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11990/2//COMMIT_MSG@14
PS2, Line 14: the order makes sense, because the 'GSUP_IEs' type is a record,
"the order makes a difference"


https://gerrit.osmocom.org/#/c/11990/2//COMMIT_MSG@19
PS2, Line 19: in a way that is used by the libosmocore's GSUP encoder.
and again, does this affect the outcome of any tests?



-- 
To view, visit https://gerrit.osmocom.org/11990
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb2314f6a9ab0e9fc5e836390414cec6e1a12db
Gerrit-Change-Number: 11990
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Nov 2018 14:21:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181129/156a40e9/attachment.html>


More information about the gerrit-log mailing list