Change in osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: fix missing session state IE in PROC_SS_ERR

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 29 14:12:47 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11984 )

Change subject: library/GSUP_Types.ttcn: fix missing session state IE in PROC_SS_ERR
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/11984/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11984/2//COMMIT_MSG@19
PS2, Line 19: affected matching statements were also corrected.
I still need to know whether this affects the test runs somehow. Did they fail before and work now? No changes? ...? Surely, changing the expected IEs must have *some* effect on the test runs?



-- 
To view, visit https://gerrit.osmocom.org/11984
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44070396ce7119eab4608d9f9fb090bb223dfaa2
Gerrit-Change-Number: 11984
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Nov 2018 14:12:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181129/ecdae4ec/attachment.html>


More information about the gerrit-log mailing list