Change in osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: fix missing session state IE in PROC_SS_ERR

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Nov 29 14:23:57 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11984 )

Change subject: library/GSUP_Types.ttcn: fix missing session state IE in PROC_SS_ERR
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11984/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11984/2//COMMIT_MSG@19
PS2, Line 19: affected matching statements were also corrected.
> I still need to know whether this affects the test runs somehow. […]
They didn't fail. This change doesn't affect successful
test case executions. But *if* something would go wrong on
the HLR side, the matching statements wouldn't match the
expected PROC_SS_ERR messages, then hang for some time,
and finally fail due to the guard timeout...

I can also point this out in the commit message.



-- 
To view, visit https://gerrit.osmocom.org/11984
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44070396ce7119eab4608d9f9fb090bb223dfaa2
Gerrit-Change-Number: 11984
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 29 Nov 2018 14:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181129/de61b8df/attachment.html>


More information about the gerrit-log mailing list