Change in libosmocore[master]: NS: fix formatting in gprs_nsvc_state_append()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Thu Nov 22 17:02:47 UTC 2018


Max has uploaded this change for review. ( https://gerrit.osmocom.org/11887


Change subject: NS: fix formatting in gprs_nsvc_state_append()
......................................................................

NS: fix formatting in gprs_nsvc_state_append()

This function so far has been used in ctrl interface only where we do
not need any explicit formatting. Let's drop the '\n' - if there'll be
users outside of ctrl protocol context, they can add it while printing
the result of gprs_nsvc_state_append().

Change-Id: I15ba8779d5100ebeb05ffc99271ba57c6bc4de14
Related: SYS#2655
---
M src/gb/gprs_ns.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/11887/1

diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c
index 1281c9f..c93c5b9 100644
--- a/src/gb/gprs_ns.c
+++ b/src/gb/gprs_ns.c
@@ -1727,7 +1727,7 @@
 char *gprs_nsvc_state_append(char *s, struct gprs_nsvc *nsvc)
 {
 	s = talloc_asprintf_append(s,
-		"%u,%u,%s,%s,%s,%s,%s\n",
+		"%u,%u,%s,%s,%s,%s,%s",
 		nsvc->nsei, nsvc->nsvci,
 		NS_DESC_A(nsvc->state),
 		NS_DESC_B(nsvc->state),

-- 
To view, visit https://gerrit.osmocom.org/11887
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15ba8779d5100ebeb05ffc99271ba57c6bc4de14
Gerrit-Change-Number: 11887
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181122/de9b1d8f/attachment.htm>


More information about the gerrit-log mailing list