This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/11887 ) Change subject: NS: fix formatting in gprs_nsvc_state_append() ...................................................................... Patch Set 1: Code-Review-1 I don't think this is correct - \n is how we separate different records from one another. See gb_proxy_ctrl.c in osmo-sgsn for example. Ctrl cmd get_nsvc_state will iterate though all NSVCs and append their state. The individual entries in a state are separated by commas, but with your change there would be no separation at all between NS_DESC_B(nsvc->remote_state) of one NSVC and nsvc->nsei of the next. -- To view, visit https://gerrit.osmocom.org/11887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15ba8779d5100ebeb05ffc99271ba57c6bc4de14 Gerrit-Change-Number: 11887 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Comment-Date: Fri, 23 Nov 2018 15:27:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181123/73f1f338/attachment.htm>