Change in osmo-bts[master]: common/vty.c: fix deprecated osmo_str2lower() usage

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Nov 22 07:55:42 UTC 2018


Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11872


Change subject: common/vty.c: fix deprecated osmo_str2lower() usage
......................................................................

common/vty.c: fix deprecated osmo_str2lower() usage

Change-Id: I4f78bc13908c2d9dfbe24195ae6e35fae8575c59
---
M src/common/vty.c
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/72/11872/1

diff --git a/src/common/vty.c b/src/common/vty.c
index 7c2900f..bb88c57 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -259,7 +259,7 @@
 static void config_write_bts_single(struct vty *vty, struct gsm_bts *bts)
 {
 	struct gsm_bts_trx *trx;
-	char buf_casecnvt[256];
+	const char *sapi_buf;
 	int i;
 
 	vty_out(vty, "bts %u%s", bts->nr, VTY_NEWLINE);
@@ -291,13 +291,13 @@
 
 	for (i = 0; i < 32; i++) {
 		if (gsmtap_sapi_mask & (1 << i)) {
-			osmo_str2lower(buf_casecnvt, get_value_string(gsmtap_sapi_names, i));
-			vty_out(vty, " gsmtap-sapi %s%s", buf_casecnvt, VTY_NEWLINE);
+			sapi_buf = osmo_str_tolower(get_value_string(gsmtap_sapi_names, i));
+			vty_out(vty, " gsmtap-sapi %s%s", sapi_buf, VTY_NEWLINE);
 		}
 	}
 	if (gsmtap_sapi_acch) {
-		osmo_str2lower(buf_casecnvt, get_value_string(gsmtap_sapi_names, GSMTAP_CHANNEL_ACCH));
-		vty_out(vty, " gsmtap-sapi %s%s", buf_casecnvt, VTY_NEWLINE);
+		sapi_buf = osmo_str_tolower(get_value_string(gsmtap_sapi_names, GSMTAP_CHANNEL_ACCH));
+		vty_out(vty, " gsmtap-sapi %s%s", sapi_buf, VTY_NEWLINE);
 	}
 	vty_out(vty, " min-qual-rach %.0f%s", bts->min_qual_rach * 10.0f,
 		VTY_NEWLINE);

-- 
To view, visit https://gerrit.osmocom.org/11872
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f78bc13908c2d9dfbe24195ae6e35fae8575c59
Gerrit-Change-Number: 11872
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181122/d909b044/attachment.html>


More information about the gerrit-log mailing list