Change in osmo-ggsn[master]: properly store IPv6 addresses in struct tun_t

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Nov 22 17:28:23 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11871 )

Change subject: properly store IPv6 addresses in struct tun_t
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11871/1/lib/tun.c
File lib/tun.c:

https://gerrit.osmocom.org/#/c/11871/1/lib/tun.c@279
PS1, Line 279: 		netdev_delroute(&tun->dstaddr.v4, &tun->addr.v4, &tun->netmask);
> Yes it looks wrong. But I'd prefer to not mix functional changes in here.
Sure, just make sure to push a patch for it if possible, or open a ticket or whatever.



-- 
To view, visit https://gerrit.osmocom.org/11871
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd2431ad25d7fa182e52e2bd5231ceb04d427c34
Gerrit-Change-Number: 11871
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 22 Nov 2018 17:28:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181122/77e1df87/attachment.html>


More information about the gerrit-log mailing list