Change in osmo-bsc[master]: paging: Add VTY options to calculate T3113 timeout dynamically

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Nov 21 13:48:41 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11654 )

Change subject: paging: Add VTY options to calculate T3113 timeout dynamically
......................................................................


Patch Set 3: Code-Review+1

(6 comments)

I can't really make up my mind whether a general 'dynamic' setting for all timers will ever make sense. I imagine, if we have other dynamic timers, they will probably follow own semantics, and likely a simple on/off setting won't cut it. So if a dynamic timer ever needs more specific configuration, the scheme of having one command for all breaks? So maybe a '[no] paging-timeout-dynamic' would be simpler?

I accept your decision though.

https://gerrit.osmocom.org/#/c/11654/3/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/#/c/11654/3/src/osmo-bsc/bsc_vty.c@3893
PS3, Line 3893: 	"Calculate T3113 dynamically based on channel config and load\n"
slightly weird: this looks like a general command, yet names T3113 specifically in the doc?

  "Use dynamically calculated timer value. Timers currently supporting a dynamic setting are:"
  " T3113 based on channel config and load."

well ... ok if T3113 is currently the only one, just need to make sure to change it if more show up.


https://gerrit.osmocom.org/#/c/11654/3/src/osmo-bsc/bsc_vty.c@3903
PS3, Line 3903: 	if (d->T != 3113) {
similarly, might already structure this as a switch()... well whatever


https://gerrit.osmocom.org/#/c/11654/3/src/osmo-bsc/bsc_vty.c@3916
PS3, Line 3916: 	"Calculate T3113 dynamically based on channel config and load\n"
with the preceding "no", it's ok to here write "Set given timer to non-dynamic and use the default or user provided fixed value". A conflict only arises if the same token at the same position has differing docs -- only one of them will survive in the online documentation.


https://gerrit.osmocom.org/#/c/11654/3/src/osmo-bsc/bsc_vty.c@3927
PS3, Line 3927: 		vty_out(vty, "T%d has no dynamic setting%s", d->T, VTY_NEWLINE);
technically would be ok to ignore this, because setting a non-dynamic timer to non-dynamic is a no-op, right?


https://gerrit.osmocom.org/#/c/11654/3/src/osmo-bsc/paging.c
File src/osmo-bsc/paging.c:

https://gerrit.osmocom.org/#/c/11654/3/src/osmo-bsc/paging.c@270
PS3, Line 270: 	return 0;
(unrelated ws)


https://gerrit.osmocom.org/#/c/11654/3/src/osmo-bsc/paging.c@290
PS3, Line 290: 
(one more blank line than usual)



-- 
To view, visit https://gerrit.osmocom.org/11654
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f
Gerrit-Change-Number: 11654
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Nov 2018 13:48:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181121/cd3eaa52/attachment.html>


More information about the gerrit-log mailing list