Change in osmo-bsc[master]: paging: Add VTY options to calculate T3113 timeout dynamically

Neels Hofmeyr gerrit-no-reply at
Wed Nov 21 13:48:41 UTC 2018

Neels Hofmeyr has posted comments on this change. ( )

Change subject: paging: Add VTY options to calculate T3113 timeout dynamically

Patch Set 3: Code-Review+1


I can't really make up my mind whether a general 'dynamic' setting for all timers will ever make sense. I imagine, if we have other dynamic timers, they will probably follow own semantics, and likely a simple on/off setting won't cut it. So if a dynamic timer ever needs more specific configuration, the scheme of having one command for all breaks? So maybe a '[no] paging-timeout-dynamic' would be simpler?

I accept your decision though.
File src/osmo-bsc/bsc_vty.c:
PS3, Line 3893: 	"Calculate T3113 dynamically based on channel config and load\n"
slightly weird: this looks like a general command, yet names T3113 specifically in the doc?

  "Use dynamically calculated timer value. Timers currently supporting a dynamic setting are:"
  " T3113 based on channel config and load."

well ... ok if T3113 is currently the only one, just need to make sure to change it if more show up.
PS3, Line 3903: 	if (d->T != 3113) {
similarly, might already structure this as a switch()... well whatever
PS3, Line 3916: 	"Calculate T3113 dynamically based on channel config and load\n"
with the preceding "no", it's ok to here write "Set given timer to non-dynamic and use the default or user provided fixed value". A conflict only arises if the same token at the same position has differing docs -- only one of them will survive in the online documentation.
PS3, Line 3927: 		vty_out(vty, "T%d has no dynamic setting%s", d->T, VTY_NEWLINE);
technically would be ok to ignore this, because setting a non-dynamic timer to non-dynamic is a no-op, right?
File src/osmo-bsc/paging.c:
PS3, Line 270: 	return 0;
(unrelated ws)
PS3, Line 290: 
(one more blank line than usual)

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f
Gerrit-Change-Number: 11654
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at>
Gerrit-Reviewer: Harald Welte <laforge at>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at>
Gerrit-Comment-Date: Wed, 21 Nov 2018 13:48:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list