Change in osmo-bsc[master]: paging: Add VTY options to calculate T3113 timeout dynamically

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Thu Nov 22 15:23:33 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11654 )

Change subject: paging: Add VTY options to calculate T3113 timeout dynamically
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/11654/3/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/#/c/11654/3/src/osmo-bsc/bsc_vty.c@3893
PS3, Line 3893: 	"Calculate T3113 dynamically based on channel config and load\n"
> slightly weird: this looks like a general command, yet names T3113 specifically in the doc? […]
I think it would be good to make the name of this command more specific to t3113, for now.



-- 
To view, visit https://gerrit.osmocom.org/11654
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f
Gerrit-Change-Number: 11654
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Comment-Date: Thu, 22 Nov 2018 15:23:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181122/c3e704db/attachment.html>


More information about the gerrit-log mailing list