Change in osmo-sip-connector[master]: Add Cause to DISCONNECT and RELEASE Requests

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Keith Whyte gerrit-no-reply at lists.osmocom.org
Wed May 23 22:45:15 UTC 2018


Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/9270


Change subject: Add Cause to DISCONNECT and RELEASE Requests
......................................................................

Add Cause to DISCONNECT and RELEASE Requests

GSM 04.08 10.5.4.11 (Table 10.85) states:

Coding standards other than the standard defined for the
GSM PLMNS shall not be used if the cause can be represented
with the GSM standardized coding.

This patch adds cause coding GSM PLMS (3) and sets cause
location to  "public network serving the local user" (2)
This prevents UE that pay attention to this from treating
all call termination as an error and paves the way to
adding correct cause mapping from Table 10.86

Change-Id: I5d3fe3f0c9e8de26dd0c73b10b7e4fc63dff3952
---
M src/mncc.c
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/70/9270/1

diff --git a/src/mncc.c b/src/mncc.c
index 0feb12e..f307dcf 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -107,6 +107,11 @@
 {
 	mncc->msg_type = msg_type;
 	mncc->callref = callref;
+	if (MNCC_DISC_REQ == msg_type || MNCC_REL_REQ == msg_type) {
+		mncc->fields |= MNCC_F_CAUSE;
+		mncc->cause.coding = 3;
+		mncc->cause.location = 2;
+	}
 }
 
 static void mncc_write(struct mncc_connection *conn, struct gsm_mncc *mncc, uint32_t callref)

-- 
To view, visit https://gerrit.osmocom.org/9270
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d3fe3f0c9e8de26dd0c73b10b7e4fc63dff3952
Gerrit-Change-Number: 9270
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180523/28659b9e/attachment.htm>


More information about the gerrit-log mailing list