This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9270 ) Change subject: Add Cause to DISCONNECT and RELEASE Requests ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/9270/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/9270/1/src/mncc.c@113 PS1, Line 113: mncc->cause.location = 2; please use GSM48_CAUSE_LOC_PUN_S_LU instead of a magic number "2". As for "coding", it appears we might not yet have a #define or enum for that. Please add it to libosmocore, and use it from here. Thanks! -- To view, visit https://gerrit.osmocom.org/9270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d3fe3f0c9e8de26dd0c73b10b7e4fc63dff3952 Gerrit-Change-Number: 9270 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <keith at rhizomatica.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 24 May 2018 08:35:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180524/d3ebeab9/attachment.htm>