This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9164 Change subject: UL TBF: Actually raise V(Q) in raise_v_q() method ...................................................................... UL TBF: Actually raise V(Q) in raise_v_q() method So far the method only printed that it was raising V(Q) but never actually did so. The increment statement was only in the log statement, its result never store to the actual m_v_q member variable. Change-Id: I699ebf6d1fceec655585e430711f59648b525728 --- M src/rlc.cpp 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/64/9164/1 diff --git a/src/rlc.cpp b/src/rlc.cpp index a82f550..59061f3 100644 --- a/src/rlc.cpp +++ b/src/rlc.cpp @@ -294,11 +294,13 @@ uint16_t count = 0; while (v_q() != v_r()) { + uint16_t v_q_old; if (!m_v_n.is_received(v_q())) break; + v_q_old = v_q(); + set_v_q(mod_sns(v_q() + 1)); LOGP(DRLCMACUL, LOGL_DEBUG, "- Taking block %d out, raising " - "V(Q) to %d\n", v_q(), mod_sns(v_q() + 1)); - raise_v_q(1); + "V(Q) to %d\n", v_q_old, v_q()); count += 1; } -- To view, visit https://gerrit.osmocom.org/9164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I699ebf6d1fceec655585e430711f59648b525728 Gerrit-Change-Number: 9164 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180515/360d2cb1/attachment.htm>