<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9164">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">UL TBF: Actually raise V(Q) in raise_v_q() method<br><br>So far the method only printed that it was raising V(Q) but never<br>actually did so.  The increment statement was only in the log<br>statement, its result never store to the actual m_v_q member variable.<br><br>Change-Id: I699ebf6d1fceec655585e430711f59648b525728<br>---<br>M src/rlc.cpp<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/64/9164/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/rlc.cpp b/src/rlc.cpp</span><br><span>index a82f550..59061f3 100644</span><br><span>--- a/src/rlc.cpp</span><br><span>+++ b/src/rlc.cpp</span><br><span>@@ -294,11 +294,13 @@</span><br><span>         uint16_t count = 0;</span><br><span> </span><br><span>      while (v_q() != v_r()) {</span><br><span style="color: hsl(120, 100%, 40%);">+              uint16_t v_q_old;</span><br><span>            if (!m_v_n.is_received(v_q()))</span><br><span>                       break;</span><br><span style="color: hsl(120, 100%, 40%);">+                v_q_old = v_q();</span><br><span style="color: hsl(120, 100%, 40%);">+              set_v_q(mod_sns(v_q() + 1));</span><br><span>                 LOGP(DRLCMACUL, LOGL_DEBUG, "- Taking block %d out, raising "</span><br><span style="color: hsl(0, 100%, 40%);">-                 "V(Q) to %d\n", v_q(), mod_sns(v_q() + 1));</span><br><span style="color: hsl(0, 100%, 40%);">-           raise_v_q(1);</span><br><span style="color: hsl(120, 100%, 40%);">+                 "V(Q) to %d\n", v_q_old, v_q());</span><br><span>           count += 1;</span><br><span>  }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9164">change 9164</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9164"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I699ebf6d1fceec655585e430711f59648b525728 </div>
<div style="display:none"> Gerrit-Change-Number: 9164 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>