This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9910 ) Change subject: UART: make IRQ/ISR enabling simpler ...................................................................... UART: make IRQ/ISR enabling simpler Change-Id: Id3742850eb5bac91559e0c2b4144bd7b1ae5b07b --- M firmware/libboard/common/source/uart_console.c 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/firmware/libboard/common/source/uart_console.c b/firmware/libboard/common/source/uart_console.c index fe64922..9004197 100644 --- a/firmware/libboard/common/source/uart_console.c +++ b/firmware/libboard/common/source/uart_console.c @@ -150,16 +150,12 @@ } /* Only store input if buffer is not full, else drop it */ - bool trigger_isr = false; - if (rbuf_is_empty(&uart_tx_buffer)) { - trigger_isr = true; - } if (!rbuf_is_full(&uart_tx_buffer)) { rbuf_write(&uart_tx_buffer, c); - } - if (trigger_isr) { - pUart->UART_IER = UART_IER_TXRDY; - CONSOLE_ISR(); + if (!(pUart->UART_IMR & UART_IMR_TXRDY)) { + pUart->UART_IER = UART_IER_TXRDY; + CONSOLE_ISR(); + } } } -- To view, visit https://gerrit.osmocom.org/9910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id3742850eb5bac91559e0c2b4144bd7b1ae5b07b Gerrit-Change-Number: 9910 Gerrit-PatchSet: 1 Gerrit-Owner: Kévin Redon <kredon at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180707/7be9627f/attachment.htm>