<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9910">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">UART: make IRQ/ISR enabling simpler<br><br>Change-Id: Id3742850eb5bac91559e0c2b4144bd7b1ae5b07b<br>---<br>M firmware/libboard/common/source/uart_console.c<br>1 file changed, 4 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libboard/common/source/uart_console.c b/firmware/libboard/common/source/uart_console.c</span><br><span>index fe64922..9004197 100644</span><br><span>--- a/firmware/libboard/common/source/uart_console.c</span><br><span>+++ b/firmware/libboard/common/source/uart_console.c</span><br><span>@@ -150,16 +150,12 @@</span><br><span> }
</span><br><span> </span><br><span> /* Only store input if buffer is not full, else drop it */
</span><br><span style="color: hsl(0, 100%, 40%);">- bool trigger_isr = false;
</span><br><span style="color: hsl(0, 100%, 40%);">- if (rbuf_is_empty(&uart_tx_buffer)) {
</span><br><span style="color: hsl(0, 100%, 40%);">- trigger_isr = true;
</span><br><span style="color: hsl(0, 100%, 40%);">- }
</span><br><span> if (!rbuf_is_full(&uart_tx_buffer)) {
</span><br><span> rbuf_write(&uart_tx_buffer, c);
</span><br><span style="color: hsl(0, 100%, 40%);">- }
</span><br><span style="color: hsl(0, 100%, 40%);">- if (trigger_isr) {
</span><br><span style="color: hsl(0, 100%, 40%);">- pUart->UART_IER = UART_IER_TXRDY;
</span><br><span style="color: hsl(0, 100%, 40%);">- CONSOLE_ISR();
</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!(pUart->UART_IMR & UART_IMR_TXRDY)) {
</span><br><span style="color: hsl(120, 100%, 40%);">+ pUart->UART_IER = UART_IER_TXRDY;
</span><br><span style="color: hsl(120, 100%, 40%);">+ CONSOLE_ISR();
</span><br><span style="color: hsl(120, 100%, 40%);">+ }
</span><br><span> }
</span><br><span> }
</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9910">change 9910</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9910"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id3742850eb5bac91559e0c2b4144bd7b1ae5b07b </div>
<div style="display:none"> Gerrit-Change-Number: 9910 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>