This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12436 Change subject: layer23/sap_interface.c: drop redundant length check ...................................................................... layer23/sap_interface.c: drop redundant length check In sap_read() we read() up to 'max_msg_size' bytes, so this check is redundant and doesn't make any sense. Change-Id: I3be5f0ea742c1ecd3df8c60db0d4de5691b14cfc --- M src/host/layer23/src/common/sap_interface.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/36/12436/1 diff --git a/src/host/layer23/src/common/sap_interface.c b/src/host/layer23/src/common/sap_interface.c index dd7737a..69de5bb 100644 --- a/src/host/layer23/src/common/sap_interface.c +++ b/src/host/layer23/src/common/sap_interface.c @@ -297,10 +297,6 @@ static void sap_parse_resp(struct osmocom_ms *ms, uint8_t *data, uint16_t len) { struct sap_msg *msg = NULL; - if(len > ms->sap_entity.max_msg_size){ - LOGP(DSAP, LOGL_ERROR, "Read more data than allowed by max_msg_size, ignoring.\n"); - return; - } msg = sap_parse_msg(data); if(!msg){ -- To view, visit https://gerrit.osmocom.org/12436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3be5f0ea742c1ecd3df8c60db0d4de5691b14cfc Gerrit-Change-Number: 12436 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181224/1c8c91a5/attachment.htm>