<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12436">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">layer23/sap_interface.c: drop redundant length check<br><br>In sap_read() we read() up to 'max_msg_size' bytes, so this<br>check is redundant and doesn't make any sense.<br><br>Change-Id: I3be5f0ea742c1ecd3df8c60db0d4de5691b14cfc<br>---<br>M src/host/layer23/src/common/sap_interface.c<br>1 file changed, 0 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/36/12436/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/common/sap_interface.c b/src/host/layer23/src/common/sap_interface.c</span><br><span>index dd7737a..69de5bb 100644</span><br><span>--- a/src/host/layer23/src/common/sap_interface.c</span><br><span>+++ b/src/host/layer23/src/common/sap_interface.c</span><br><span>@@ -297,10 +297,6 @@</span><br><span> static void sap_parse_resp(struct osmocom_ms *ms, uint8_t *data, uint16_t len)</span><br><span> {</span><br><span>  struct sap_msg *msg = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-     if(len > ms->sap_entity.max_msg_size){</span><br><span style="color: hsl(0, 100%, 40%);">-            LOGP(DSAP, LOGL_ERROR, "Read more data than allowed by max_msg_size, ignoring.\n");</span><br><span style="color: hsl(0, 100%, 40%);">-           return;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> </span><br><span>        msg = sap_parse_msg(data);</span><br><span>   if(!msg){</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12436">change 12436</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12436"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3be5f0ea742c1ecd3df8c60db0d4de5691b14cfc </div>
<div style="display:none"> Gerrit-Change-Number: 12436 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>