Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Dec 12 17:54:28 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12243 )

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
......................................................................


Patch Set 2:

> Let me try again:
 > 
 > Assume this name is used by active GSUP connections. If this name
 > is changed via VTY, what should happen to those active connections?
 > Should those connections be left as they are? Should they be
 > replaced with new connections which use the new name? I don't think
 > there is a trivial answer, is there?
 > 
 > I believe the easiest answer is that changing this name should
 > require a restart of osmo-sgsn (and likewise osmo-msc).
 > 

They can be left as they are I guess. You can try re-establishing them in the patch if you see it's easy to do so with current code base.
I think it's fine requiring the user to re-start the process for the change to take effect, I was just pointing out that independent of that topic, there should be a "no foobar" for the reason I introduced.


 > If there was a way to mark a VTY option such that it can only be
 > set while the configuration file is being loaded, and not via a
 > run-time VTY shell, then this option would be a good candidate for
 > such treatment.

Agree, that would be handy in general.
You could otherwise check if the link towards the HLR is ON when the VTY command is run, and if  that's the case, print warning stating it won't be applied until it is reconnected. But still save the new value in order to be able to save the changed config if the user desires to do so.


-- 
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Wed, 12 Dec 2018 17:54:28 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181212/08e98e5a/attachment.htm>


More information about the gerrit-log mailing list