This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgStefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg ...................................................................... Patch Set 2: > Patch Set 2: > > > They can be left as they are I guess. You can try re-establishing them in the patch if you see it's easy to do so with current code base. No, I am not going to work on that because I don't think your suggested approach makes any sense. A program restart will look like one GSUP peer and route going away and a new GSUP peer and route appearing. And everything that needs to happen for this is already implemented by our current code. Compared to simply requiring that the problem be restarted. adding additional code paths to handle dynamic peer name and route changes at run-time carries a huge potential for bugs and side-effects. Perhaps this is a weak analogy but: A routing protocol daemon (such as OSPF) won't change its router ID at run-time either. > I think it's fine requiring the user to re-start the process for the change to take effect, I was just pointing out that independent of that topic, there should be a "no foobar" for the reason I introduced. I don't see a beneficial use case in clearing the IPA name before saving the current config. Why would anyone want to omit that name? If we require the name to be stored in the config file, why should it not always be saved when the file gets written out? -- To view, visit https://gerrit.osmocom.org/12243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f Gerrit-Change-Number: 12243 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling <stsp at stsp.name> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name> Gerrit-Comment-Date: Thu, 13 Dec 2018 08:59:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181213/5493e40b/attachment.htm>