This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has uploaded this change for review. ( https://gerrit.osmocom.org/10690 Change subject: mgcp_client_fsm: switch to MGCP_CONN_RECV_SEND in add_audio() ...................................................................... mgcp_client_fsm: switch to MGCP_CONN_RECV_SEND in add_audio() The change Ie51cc86e90ffeca5b66bcb8f6db0d389241abe57 has replaced the functions make_crcx_msg_bind() and make_crcx_msg_bind_connect() with make_crcx_msg() and add_audio(). When a bidirectional connection is needed, the user calls add_audio() to add the remaining connection details. Unfortunately add_audio() leaves the conn_mode struct member unchanged. Which means the connection is still at MGCP_CONN_RECV_ONLY, which will instruct the MGW not to forward any of the received packets. - Make sure that conn_mode is set to MGCP_CONN_RECV_SEND when add_audio() is called. Change-Id: Id12de37797de5af5cc447642d2fbb1af7de680df Closes: OS#3511 --- M src/libosmo-mgcp-client/mgcp_client_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/10690/1 diff --git a/src/libosmo-mgcp-client/mgcp_client_fsm.c b/src/libosmo-mgcp-client/mgcp_client_fsm.c index 0b5a251..5368ec3 100644 --- a/src/libosmo-mgcp-client/mgcp_client_fsm.c +++ b/src/libosmo-mgcp-client/mgcp_client_fsm.c @@ -131,6 +131,7 @@ mgcp_msg->presence |= MGCP_MSG_PRESENCE_AUDIO_IP | MGCP_MSG_PRESENCE_AUDIO_PORT; mgcp_msg->audio_ip = info->addr; mgcp_msg->audio_port = info->port; + mgcp_msg->conn_mode = MGCP_CONN_RECV_SEND; } static struct msgb *make_mdcx_msg(struct mgcp_ctx *mgcp_ctx) -- To view, visit https://gerrit.osmocom.org/10690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id12de37797de5af5cc447642d2fbb1af7de680df Gerrit-Change-Number: 10690 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180829/44fc4063/attachment.htm>