<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10690">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgcp_client_fsm: switch to MGCP_CONN_RECV_SEND in add_audio()<br><br>The change Ie51cc86e90ffeca5b66bcb8f6db0d389241abe57 has replaced the<br>functions make_crcx_msg_bind() and make_crcx_msg_bind_connect() with<br>make_crcx_msg() and add_audio(). When a bidirectional connection is<br>needed, the user calls add_audio() to add the remaining connection<br>details. Unfortunately add_audio() leaves the conn_mode struct member<br>unchanged. Which means the connection is still at MGCP_CONN_RECV_ONLY,<br>which will instruct the MGW not to forward any of the received packets.<br><br>- Make sure that conn_mode is set to MGCP_CONN_RECV_SEND when<br>  add_audio() is called.<br><br>Change-Id: Id12de37797de5af5cc447642d2fbb1af7de680df<br>Closes: OS#3511<br>---<br>M src/libosmo-mgcp-client/mgcp_client_fsm.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/10690/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp-client/mgcp_client_fsm.c b/src/libosmo-mgcp-client/mgcp_client_fsm.c</span><br><span>index 0b5a251..5368ec3 100644</span><br><span>--- a/src/libosmo-mgcp-client/mgcp_client_fsm.c</span><br><span>+++ b/src/libosmo-mgcp-client/mgcp_client_fsm.c</span><br><span>@@ -131,6 +131,7 @@</span><br><span>      mgcp_msg->presence |= MGCP_MSG_PRESENCE_AUDIO_IP | MGCP_MSG_PRESENCE_AUDIO_PORT;</span><br><span>  mgcp_msg->audio_ip = info->addr;</span><br><span>       mgcp_msg->audio_port = info->port;</span><br><span style="color: hsl(120, 100%, 40%);">+      mgcp_msg->conn_mode = MGCP_CONN_RECV_SEND;</span><br><span> }</span><br><span> </span><br><span> static struct msgb *make_mdcx_msg(struct mgcp_ctx *mgcp_ctx)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10690">change 10690</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10690"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id12de37797de5af5cc447642d2fbb1af7de680df </div>
<div style="display:none"> Gerrit-Change-Number: 10690 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>