Change in osmo-bts[master]: measurement: fix measurement interval end detection

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Aug 22 19:52:14 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10564 )

Change subject: measurement: fix measurement interval end detection
......................................................................

measurement: fix measurement interval end detection

for SDDCH4 channels, the detection is not working correctly since the
function uses the lookup table for SDCCH8 interval endings there. This
needs to be corrected. Also there are two unnecessary assignments in
the code which should be removed.

- use correct table (sdcch4_meas_rep_fn102 instead of
  sdcch8_meas_rep_fn102.
- remove unnecessary assignments to last_fn_mod

Change-Id: If8a269ecd3f9fa4eeadf379114db816ef5c77d77
Related: OS#2975
---
M src/common/measurement.c
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/measurement.c b/src/common/measurement.c
index 41844b1..cb45e6e 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -328,7 +328,6 @@
 		break;
 	case GSM_PCHAN_TCH_H:
 		modulus = 104;
-		last_fn_mod = lchan->meas.last_fn % 104;
 		if (lchan->nr == 0)
 			tbl = tchh0_meas_rep_fn104;
 		else
@@ -339,13 +338,12 @@
 	case GSM_PCHAN_SDCCH8_SACCH8C:
 	case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
 		modulus = 102;
-		last_fn_mod = lchan->meas.last_fn % 102;
 		interval_end = sdcch8_meas_rep_fn102[lchan->ts->nr];
 		break;
 	case GSM_PCHAN_CCCH_SDCCH4:
 	case GSM_PCHAN_CCCH_SDCCH4_CBCH:
 		modulus = 102;
-		interval_end = sdcch8_meas_rep_fn102[lchan->ts->nr];
+		interval_end = sdcch4_meas_rep_fn102[lchan->ts->nr];
 		break;
 	default:
 		return false;

-- 
To view, visit https://gerrit.osmocom.org/10564
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If8a269ecd3f9fa4eeadf379114db816ef5c77d77
Gerrit-Change-Number: 10564
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180822/30f56b73/attachment.htm>


More information about the gerrit-log mailing list