<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10564">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">measurement: fix measurement interval end detection<br><br>for SDDCH4 channels, the detection is not working correctly since the<br>function uses the lookup table for SDCCH8 interval endings there. This<br>needs to be corrected. Also there are two unnecessary assignments in<br>the code which should be removed.<br><br>- use correct table (sdcch4_meas_rep_fn102 instead of<br>  sdcch8_meas_rep_fn102.<br>- remove unnecessary assignments to last_fn_mod<br><br>Change-Id: If8a269ecd3f9fa4eeadf379114db816ef5c77d77<br>Related: OS#2975<br>---<br>M src/common/measurement.c<br>1 file changed, 1 insertion(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/measurement.c b/src/common/measurement.c</span><br><span>index 41844b1..cb45e6e 100644</span><br><span>--- a/src/common/measurement.c</span><br><span>+++ b/src/common/measurement.c</span><br><span>@@ -328,7 +328,6 @@</span><br><span>             break;</span><br><span>       case GSM_PCHAN_TCH_H:</span><br><span>                modulus = 104;</span><br><span style="color: hsl(0, 100%, 40%);">-          last_fn_mod = lchan->meas.last_fn % 104;</span><br><span>          if (lchan->nr == 0)</span><br><span>                       tbl = tchh0_meas_rep_fn104;</span><br><span>          else</span><br><span>@@ -339,13 +338,12 @@</span><br><span>         case GSM_PCHAN_SDCCH8_SACCH8C:</span><br><span>       case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:</span><br><span>          modulus = 102;</span><br><span style="color: hsl(0, 100%, 40%);">-          last_fn_mod = lchan->meas.last_fn % 102;</span><br><span>          interval_end = sdcch8_meas_rep_fn102[lchan->ts->nr];</span><br><span>           break;</span><br><span>       case GSM_PCHAN_CCCH_SDCCH4:</span><br><span>  case GSM_PCHAN_CCCH_SDCCH4_CBCH:</span><br><span>             modulus = 102;</span><br><span style="color: hsl(0, 100%, 40%);">-          interval_end = sdcch8_meas_rep_fn102[lchan->ts->nr];</span><br><span style="color: hsl(120, 100%, 40%);">+            interval_end = sdcch4_meas_rep_fn102[lchan->ts->nr];</span><br><span>           break;</span><br><span>       default:</span><br><span>             return false;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10564">change 10564</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10564"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: If8a269ecd3f9fa4eeadf379114db816ef5c77d77 </div>
<div style="display:none"> Gerrit-Change-Number: 10564 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>