libosmocore[master]: Expand bitvec_write_field()

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Oct 23 17:47:17 UTC 2017


Patch Set 6: Code-Review-1

Is still think we should not abuse a function that writes an unsigned integer for writing anything else (such as LH values).

the specs (correct me if I'm wrong) never express a numeric/integer value as L/H.  Rather, they speak of distinct L/H values.  So if you would like to append LL or LH or HL or HH, you simply call a function that works with L and H definitions, and not one that works on integers and inputting '3'

-- 
To view, visit https://gerrit.osmocom.org/4292
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee648d764de9f3e7ef850f40864ad701c83f61db
Gerrit-PatchSet: 6
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list