libosmocore[master]: Expand bitvec_write_field()
gerrit-no-reply at lists.osmocom.org
Mon Oct 23 10:23:23 UTC 2017
Patch Set 4:
If I understood the issue correctly, than this 1-bit difference is what's required (the absence of it caused the issue). Minh?
> can the caller use the new bitvec_set_u64() instead?
Yes, and I think eventually we should. But this would require massive change to OsmoPCU encoding routines which I think is better to postpone till we have better test coverage and GPRS-related test automation.
Line 12: === total 1 bits differ ===
> is this ok??
Yes, that's the whole point of this patch series.
To view, visit https://gerrit.osmocom.org/4292
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
More information about the gerrit-log