libosmocore[master]: abis_nm: Add abis_nm_admin_name() API

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Oct 23 10:01:12 UTC 2017


Patch Set 1:

> What change will break anything? Aligning the rest of the file to
 > static inline functions? Then let's not?

This change will break building against older libosmocore versions without a good reason to do so.  The new abis_nm_admin_name() function (whether inline or real function) will not be present in older libraries.

We have to stop breaking API compatibility all the time for no good reason.  I don't think this is one.

-- 
To view, visit https://gerrit.osmocom.org/4355
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieace734aaff3f07606113feddde65b75202d96d6
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list