libosmocore[master]: abis_nm: Add abis_nm_admin_name() API
Pau Espin Pedrol
gerrit-no-reply at lists.osmocom.org
Mon Oct 23 10:11:31 UTC 2017
Patch Set 1:
> > What change will break anything? Aligning the rest of the file to
> > static inline functions? Then let's not?
> This change will break building against older libosmocore versions
> without a good reason to do so. The new abis_nm_admin_name()
> function (whether inline or real function) will not be present in
> older libraries.
> We have to stop breaking API compatibility all the time for no good
> reason. I don't think this is one.
One could argue that this patch can then be merged at some point in the future when we add/modify a new API required for osmo-bts/bsc.
I'm not really for or against merging it, but I think it's confusing having an API to get names for availability and operational state but having none for administrative ones, so I bet I won't be the last one losing time with this kind of confusions.
To view, visit https://gerrit.osmocom.org/4355
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
More information about the gerrit-log