osmo-bsc[master]: log: als output hexdump of transmitted sccp messages

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Oct 23 01:15:28 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4350/1/src/osmo-bsc/osmo_bsc_sigtran.c
File src/osmo-bsc/osmo_bsc_sigtran.c:

Line 344: 	     conn_id, osmo_hexdump(msg->data, msg->len), osmo_sccp_addr_name(ss7, &msc->a.msc_addr));
> Why not use msgb_hexdump() instead?
(if no lNh pointers are set, msgb_hexdump is basically a less optimal version of osmo_hexdump())


-- 
To view, visit https://gerrit.osmocom.org/4350
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe52a0b7dbca4c569c603a008d73d0d99d1c345
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list