osmo-bsc[master]: log: als output hexdump of transmitted sccp messages

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Oct 23 01:12:41 UTC 2017


Patch Set 1: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/4350/1//COMMIT_MSG
Commit Message:

Line 7: log: als output hexdump of transmitted sccp messages
"als"?


Line 12: Also log the hexdump of transmitted sccp messages
isn't that saying the same thing twice over? Ah yes, intentionally.


https://gerrit.osmocom.org/#/c/4350/1/src/osmo-bsc/osmo_bsc_sigtran.c
File src/osmo-bsc/osmo_bsc_sigtran.c:

Line 343: 	LOGP(DMSC, LOGL_DEBUG, "Sending connection (id=%i) oriented data (%s) to MSC: %s\n",
I'd prefer putting the hexdump at the end of the line, after "to MSC %s", so you don't have to read the whole line to find the target MSC.


-- 
To view, visit https://gerrit.osmocom.org/4350
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe52a0b7dbca4c569c603a008d73d0d99d1c345
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list