osmo-ggsn[master]: lib/ippool: Fix listsize calculated 1 elem too small

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sun Oct 15 17:33:22 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4255/1/lib/ippool.c
File lib/ippool.c:

Line 218: 		dynsize = (1 << (addr.len*8 - addrprefixlen));
> I always thought the "-1" is for the GGSN itself.  So if you have a /24 wit
I agree with all those wrong assumptions the code was difficult to understand. For instance I thought that the GATEWAY IP is the one assigned to the tun interface, but indeed it can be yet another IP. I think this patch is still OK as all this cases should be implemented by using the blacklist feature presented in next patch, perhaps by adding extra config parameters such as "ip blacklist list-of-A.B.C.D"


-- 
To view, visit https://gerrit.osmocom.org/4255
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95c24bc690490155bec9e3933d678e4668d7745f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list