osmo-ggsn[master]: lib/ippool: Fix listsize calculated 1 elem too small
gerrit-no-reply at lists.osmocom.org
Sun Oct 15 16:03:55 UTC 2017
Patch Set 1:
Line 218: dynsize = (1 << (addr.len*8 - addrprefixlen));
I always thought the "-1" is for the GGSN itself. So if you have a /24 with 256 addresses, one of the addresses is for the GGSN itself. Then you may also want to exclude the network, gateway and/or broadcast addresses in addition.
However, the existing code would have mandated the GGSN to use the highest address within the pool to work. All of those assumptions are bad anyway.
To view, visit https://gerrit.osmocom.org/4255
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
More information about the gerrit-log