[MERGED] osmo-ggsn[master]: create_context_ind(): ignore a non-started default APN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Oct 1 10:31:09 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: create_context_ind(): ignore a non-started default APN
......................................................................


create_context_ind(): ignore a non-started default APN

If the default APN has not been started, it is not eligible to be
used in starting of new PDP contexts.

Change-Id: I93b5c205c033f275824ee8bc8cdcf1428fb086df
---
M ggsn/ggsn.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c
index f8aec9d..5852ef6 100644
--- a/ggsn/ggsn.c
+++ b/ggsn/ggsn.c
@@ -451,9 +451,14 @@
 	/* ignore if the APN has not been started */
 	if (!apn->started)
 		apn = NULL;
+
 	/* then try default (if any) */
 	if (!apn)
 		apn = ggsn->cfg.default_apn;
+	/* ignore if the APN has not been started */
+	if (!apn->started)
+		apn = NULL;
+
 	if (!apn) {
 		/* no APN found for what user requested */
 		LOGPPDP(LOGL_NOTICE, pdp, "Unknown APN '%s', rejecting\n", name_buf);

-- 
To view, visit https://gerrit.osmocom.org/4121
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I93b5c205c033f275824ee8bc8cdcf1428fb086df
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list