This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (5 comments) marking -1 just to highlight question on isReal(). Also some cosmetics. https://gerrit.osmocom.org/#/c/2920/1//COMMIT_MSG Commit Message: Line 12: these cases accordingly.t "to to", ".t" https://gerrit.osmocom.org/#/c/2920/1/Transceiver52M/sigProcLib.cpp File Transceiver52M/sigProcLib.cpp: Line 644: how about c1_burst.isReal(true)? isn't that missing now? Line 660: c0_burst.isReal(false)? Line 943: shape = shapeEdgeBurst(burst); could also return shapeEdgeBurst(burst); and drop the shape var (because the final 'delete' is not needed anymore) Line 1005: shaped = convolve(&burst, pulse, NULL, START_ONLY); return convolve(...) ? -- To view, visit https://gerrit.osmocom.org/2920 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If53da1bf77b5944b6117765fa98ce12e1ccdeede Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: Tom Tsou <tom at tsou.cc> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes