osmo-trx[master]: sigProcLib: Remove heap based signal vector allocations

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Tom Tsou gerrit-no-reply at lists.osmocom.org
Thu Jun 15 00:08:28 UTC 2017


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/2920/1//COMMIT_MSG
Commit Message:

Line 12: these cases accordingly.t
> "to to", ".t"
Oops.


https://gerrit.osmocom.org/#/c/2920/1/Transceiver52M/sigProcLib.cpp
File Transceiver52M/sigProcLib.cpp:

Line 644: 
> how about c1_burst.isReal(true)? isn't that missing now?
Looking at this again, c0 should be initialized with isReal(true) and changed to isReal(false) only after GMSKRotate(). Burst c1 should be initialized with isReal(false) - the default.

So the original c1 setting was incorrect (but did not affect behavior), and the patch made c0 incorrect (disabling some optimizations). Changes are not trivial. I'll make a separate patch.


Line 943:   shape = shapeEdgeBurst(burst);
> could also
Noted.


-- 
To view, visit https://gerrit.osmocom.org/2920
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If53da1bf77b5944b6117765fa98ce12e1ccdeede
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Tom Tsou <tom at tsou.cc>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Tom Tsou <tom at tsou.cc>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list